Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do: use GOLANG_VERSION arg #113

Merged
merged 1 commit into from
May 16, 2020
Merged

Conversation

dnephin
Copy link
Member

@dnephin dnephin commented May 16, 2020

pass the arg, and use it in the iidfile cache filename so that using a different value doesn't keep using the same cached image id.

pass the arg, and use it in the iidfile cache filename so that using a
different value doesn't keep using the same cached image id.
@dnephin dnephin merged commit 1b26a76 into gotestyourself:master May 16, 2020
@dnephin dnephin deleted the do-improvements branch May 16, 2020 17:29
do
Comment on lines 31 to +38
docker run \
--tty --interactive --rm \
-v "$PWD:/work" \
-v ~/.cache/go-build:/root/.cache/go-build \
-v ~/go/pkg/mod:/go/pkg/mod \
-w /work \
"$tag" bash
"$image" \
"${@-bash}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if DOCKER_BUILDKIT=1 is an option, in that case, you could use the docker build --output=.. option to get artifacts out of the build, instead of first building, then running the image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting!

In this case I don't think there will necessarily be any output. The goal is to run an interactive shell and potentially run multiple commands in it.

If someone wants to try something against a different Go version it is a convenient way of getting a container running with that version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, gotcha; didn't look closely at all use-cases, but the --output option is very interested for "building" artefacts (and can make things a lot more simple). Only issue would be if you want to do so with native Windows containers (windows doesn't yet support buildkit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants