Use golang.org/x/sys/windows.GetConsoleScreenBufferInfo #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
/cc @dnephin |
|
Thanks! |
I think it would be perfectly acceptable to add the other functions to x/sys/windows as well. Please feel free to send a PR/CL if needed. |
gopherbot
pushed a commit
to golang/sys
that referenced
this pull request
Oct 7, 2020
Relates to gotestyourself/gotestsum#115 (comment) For details see: https://docs.microsoft.com/en-us/windows/console/SetConsoleCursorPosition Change-Id: I512428b64af253916c81187cb644e40a6ba418b5 GitHub-Last-Rev: c6c7ba0 GitHub-Pull-Request: #87 Reviewed-on: https://go-review.googlesource.com/c/sys/+/258038 Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Trust: Alex Brainman <alex.brainman@gmail.com> Trust: Tobias Klauser <tobias.klauser@gmail.com> Trust: Ian Lance Taylor <iant@golang.org> Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this is now provided by golang.org/x/sys as well. The other ones not yet (afaics)
Perhaps @tklauser knows if that's within scope of golang.org/x/sys, or if we need to continue implementing it here
(note; I don't have a Windows machine running, so have not tested it)