Store test output by ID #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that when a test case is encountered multiple times, either because -count=n was used, or because ScanTestOutput is being passed multiple instances of test runs, a failure or skipped test displays only its own output, not that of all tests with the same name. Also move addEvent to Package, it is more appropriate as a Package method, and make Package methods use a pointer receiver. Many of them update the Package.
It can be determined by using the list of skipped test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
So that when a test case is encountered multiple times, either because -count=n was used, or because ScanTestOutput is being passed multiple test runs, a failure or skipped test displays only its own output, not that of all tests with the same name.
Also move addTestEvent to Package, it is more appropriate as a Package method, and make Package methods use a pointer receiver. Many of them update the Package.
Also remove the need for hasSubtestSkipped by using the Skipped list to determine if a subtest has been skipped.