bug fixes for rerun fails #129

dnephin · 2020-06-11T03:28:41Z

add a DONE line after each attempt
abort the rerun if any run has errors
warn if go test exits with any code other than 0 or 1
./do update-golden runs go1.13 in a container to update both sets of golden files
some misc improvements to naming

It should split on any whitespace

re-run should be a no-op anyway, but out of an overabundance of caution, check it anyway.

Fix packages flag

3381e15

It should split on any whitespace

dnephin added the bug Something isn't working label Jun 11, 2020

dnephin force-pushed the rerun-fails branch 2 times, most recently from 50161bc to ac78aac Compare June 12, 2020 04:46

dnephin added 3 commits June 12, 2020 01:11

Cancel re-run if there are any errors.

ccefcdd

check goTestExitErr before rerun

e8026de

re-run should be a no-op anyway, but out of an overabundance of caution, check it anyway.

rerun: add done line, and only warn on exit !{0,1}

bb6a8a5

dnephin force-pushed the rerun-fails branch from ac78aac to 3c591f8 Compare June 12, 2020 05:27

dnephin marked this pull request as ready for review June 12, 2020 05:28

Add test to cover rerun with errors

f93909c

dnephin force-pushed the rerun-fails branch from 3c591f8 to f93909c Compare June 12, 2020 05:32

dnephin merged commit e55d7aa into master Jun 12, 2020

dnephin deleted the rerun-fails branch June 17, 2020 02:33

Provide feedback