rerun-fails: Only rerun failed subtests #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a root test case has failed subtests, only rerun those that have failed. A new hidden flag is added to restore the old behaviour of re-running the entire root test case if any subtest fails. Because of limitations of the 'go test -run' flag (github.com/golang/go/issues/39904) this required running each test in a separate 'go test' process.
dnephin
force-pushed
the
rerun-fails-only-subtests
branch
from
b1faed3
to
6c2d74f
Compare
Otherwise, when an Execution is re-used, those tests still in running will have artifitial events sent for them each time .end() is called, inflating the failure count. The test count was correct because test count is incremented in run().
dnephin
force-pushed
the
rerun-fails-only-subtests
branch
from
b1d6082
to
a18b697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a root test case has failed subtests, only rerun those that have failed. A new hidden flag is added to restore the old behaviour of re-running the entire root test case if any subtest fails.
Because of limitations of the 'go test -run' flag (golang/go#39904) this required running each test in a separate 'go test' process.
Also fixes a recently introduced bug where any incomplete tests stayed in
Execution.running, which causedExecution.end()to produce incorrect artificial events for those tests on each re-run.