rerun-fails: fix a bug that would cause an incorrect successful exit #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
fix-retry-fails-err
branch
2 times, most recently
from
ce560fc
to
823807e
Compare
To make it easier to fake os/exec.Cmd
dnephin
force-pushed
the
fix-retry-fails-err
branch
from
823807e
to
845b8ef
Compare
When some tests in the package have failed, but the last test of the package passes.
dnephin
force-pushed
the
fix-retry-fails-err
branch
from
845b8ef
to
d2cb6a7
Compare
dnephin
force-pushed
the
fix-retry-fails-err
branch
from
d2cb6a7
to
998433a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple tests in a package fail, but the last test run for the package passed.
Also includes a commit which prevents the re-run fails report from being printed if the re-run was aborted because of too many initial test failures.