Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filewatcher: fix a bug with maxDepth and comparing event.Op #157

Merged
merged 3 commits into from
Oct 25, 2020
Merged

filewatcher: fix a bug with maxDepth and comparing event.Op #157

merged 3 commits into from
Oct 25, 2020

Commits on Oct 24, 2020

  1. filewatcher: fix event.Op comparison 

    Previously it was matching all events, which caused problems in editors
like vim, which rename the file. It seemed to be running before the file
was finished writing.
    @dnephin
    dnephin committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    c11beca View commit details
    Browse the repository at this point in the history

  2. upgrade gotest.tools

    @dnephin
    dnephin committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    1c78e40 View commit details
    Browse the repository at this point in the history

  3. filewatcher: only recurse when directory has a /... suffix 

    Previously filewatcher.Watch would recurse into all directories.

Also fix a bug where max depth of the directory walk was including the root directory path in the depth.

Adds tests for a couple functions
    @dnephin
    dnephin committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    d0804e6 View commit details
    Browse the repository at this point in the history