Try out a new pattern for large table tests #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
testcases_example
branch
from
8a1d5ec
to
cb73c95
Compare
Once a table test grows past a certain point it becomes very difficult to work with. A failure in one case requires scrolling around attempting to find the case, because the failure message only includes the line in the test function, not the testCase. Instead of a slice or map of test cases, using this runCase function to add a t.Log will give the line number of the testCase as well as the line number in the test function. This makes it very easy to jump to both of the relevant lines.
dnephin
force-pushed
the
testcases_example
branch
from
cb73c95
to
d1d4c68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a table test grows past a certain point it becomes very difficult
to work with. A failure in one case requires scrolling around attempting
to find the case, because the failure message only includes the line in
the test function, not the testCase.
Instead of a slice or map of test cases, using this runCase function to
add a t.Log will give the line number of the testCase as well as the
line number in the test function. This makes it very easy to jump to
both of the relevant lines.
Best viewed with hide whitespace changes.