Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip empty tests #282

Closed
wants to merge 3 commits into from
Closed

Conversation

flowchartsman
Copy link
Contributor

First pass to fix #228

@dnephin
Copy link
Member

dnephin commented Nov 5, 2022

Thank you for working on this change!

It should be pretty easy to hide empty packages. By definition they don't have any tests, so all we should need to do is avoid printing the "end of package" event in the formatter. There currently isn't a way to pass options to formatters, but I think this is a great time to add options.

Since this is an explicit flag, I don't think we need to handle the package arg in any special way. Checking ./... is probably the most common case, but you can use the 3 dots on any package (ex: ./somepkg/... would also be valid and would match somepkg and all its subpackages).

I think we should call the flag hide instead of skip, because skip suggests a test exists and is not being run (that's how the testing package uses the term).

I put together those changes in #283 and added you as a co-author. How does that look to you? Does that seem like it solves the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suppress printing package names with no tests
2 participants