Fix need to save twice to trigger watch on OSX using Neovim #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On OSX (12.6.2) using Neovim (NVIM v0.8.2) the triggering event varies between `fsnotify.Rename` and `Create`. This fix adds `fsnotify.Rename` to the events triggering a new test run. *Before* ``` handling event "cors_middleware.go": RENAME handling event "cors_middleware.go": CREATE Running tests in ./. exec: [go test -json ./.] go test pid: 96495 ✓ . (cached) DONE 71 tests in 0.237s ``` *After* ``` handling event "cors_middleware.go": RENAME Running tests in ./. exec: [go test -json ./.] go test pid: 95707 ✓ . (cached) DONE 71 tests in 0.245s ```
|
Thank you for the bug fix! This is definitely something that needs to be fixed. I think this change should be safe because of the throttling of events, but I'd like to do a bit of testing with vim, vs code, and GoLand to make sure it continues to work correctly with those editors. The changes in this PR look great, so as long as this continues to work with those editors I think we should be able to merge this PR. |
dnephin
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OSX (12.6.2) using Neovim (NVIM v0.8.2) the triggering event varies between
fsnotify.RenameandCreate.This fix adds
fsnotify.Renameto the events triggering a new test run.Before
After