Add jsonfile-timing-events flag for capturing only the timing events in a file #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
fix-jsonfile-close-order
branch
from
48cb825
to
db13c76
Compare
dnephin
force-pushed
the
jsonfile-events
branch
from
7482705
to
0407f9d
Compare
Write the newline as a separate rune to the writer to avoid accidentally modifying the backing array, or having to allocate a new array unnecessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #305
Adds a new
--jsonfile-timing-eventsflag. Similar to--jsonfile, all of the pass, fail, and skip events are written to this file.This is useful when
gotestsumis used with large projects that emit lots of verbose logs from tests. This new flag removes the need to post-process the jsonfile before saving it to an artifact.See #303 (comment) and #258 (comment)