Use io.Writer in formatters #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests to use the new interface directly, removing the need for an adapter in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #79 first introduced support for writing output directly to an
io.Writerinstead of creating large strings in memory. PR #313 addedeventFormatterFuncso that formatters could be implemented as closures without needing a separate struct type for each.This PR converts all the formatters to use this new type. There are still a few places where strings are constructed, but all of those strings should be small. The large strings (output from running tests) should be written directly to stdout, avoiding the need to allocate large strings that are discarded immediately after writing them.