Quote test names before they are used within the regex to rerun #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noBlubb
force-pushed
the
fix/quote_testnames_for_regex
branch
from
dd19271
to
3efa4ee
Compare
dnephin
force-pushed
the
fix/quote_testnames_for_regex
branch
from
3efa4ee
to
6f6b09d
Compare
dnephin
approved these changes
Jun 16, 2023
|
Nice! Really helps to highlight the expected behavior and not get distracted by other escaping, thank you :) |
nfi-hashicorp
added a commit
to hashicorp/consul
that referenced
this pull request
Jul 11, 2023
Specifically to for this fix: gotestyourself/gotestsum#338
4 tasks
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337: The (sub) test names were not quoted before being used within the regex passed to
-runand therefore causedgo testto mis-evaluate the expression if there were parentheses contained. Uses https://pkg.go.dev/regexp#QuoteMeta to make it work for a wider range of characters.