Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rerun-fails: prevent extra runs when a sub-test fails #343

Merged
merged 2 commits into from
Jul 30, 2023
Merged

rerun-fails: prevent extra runs when a sub-test fails #343

merged 2 commits into from
Jul 30, 2023

Conversation

brycekahle
Copy link
Contributor

Addresses other part of #341

@brycekahle brycekahle mentioned this pull request Jul 14, 2023
Closed
@dnephin dnephin force-pushed the bryce.kahle/filter-to-leaves branch from 62e0504 to bf91082 Compare July 16, 2023 19:16
dnephin
dnephin approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I realized that substring matching would cause problems when one test name was a prefix of another that wasn't a subtest.

I added a couple examples to the test case. I pushed a commit that uses exact matching of the parent name instead of simply a substring match, which got those test cases passing.

How does this approach look to you? Does this seem correct?

testjson/execution.go Show resolved Hide resolved
@brycekahle
Copy link
Contributor Author

I realized that substring matching would cause problems when one test name was a prefix of another that wasn't a subtest.

I handled the top-level of this and was the reason there was TestTop and TestTop2 in the test cases. I'm realizing it may not have worked for nested though:

@brycekahle
Copy link
Contributor Author

How does this approach look to you? Does this seem correct?

Yes, it seems correct. The approach looks good. Maybe it would be helpful to add a comment explaining the approach?

@brycekahle
Copy link
Contributor Author

@dnephin looks good to merge to me. Thanks!

@dnephin dnephin changed the title filter out parent tests in FilterFailedUnique rerun-fails: prevent extra runs when a sub-test fails Jul 30, 2023
@dnephin dnephin merged commit b806793 into gotestyourself:main Jul 30, 2023
7 checks passed
@brycekahle brycekahle deleted the bryce.kahle/filter-to-leaves branch August 1, 2023 15:14
@brycekahle brycekahle mentioned this pull request Aug 4, 2023
Merged
10 tasks
oguzhand95 pushed a commit to cerbos/cerbos-sdk-go that referenced this pull request Sep 28, 2023
@renovate
chore(deps): Update go deps (#6)
2fb6927 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/cerbos/cerbos/api/genpb](https://github.com/cerbos/cerbos)
| require | digest | `0d63f1e` -> `341baa4` |
|
[github.com/grpc-ecosystem/go-grpc-middleware/v2](https://github.com/grpc-ecosystem/go-grpc-middleware)
| require | patch | `v2.0.0` -> `v2.0.1` |
| [github.com/lestrrat-go/jwx/v2](https://github.com/lestrrat-go/jwx)
| require | patch | `v2.0.12` -> `v2.0.13` |
| [google.golang.org/grpc](https://github.com/grpc/grpc-go) | require
| patch | `v1.58.0` -> `v1.58.2` |
|
[gotest.tools/gotestsum](https://github.com/gotestyourself/gotestsum)
| require | minor | `v1.10.1` -> `v1.11.0` |

---

### Release Notes

<details>
<summary>grpc-ecosystem/go-grpc-middleware
(github.com/grpc-ecosystem/go-grpc-middleware/v2)</summary>

###
[`v2.0.1`](https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.0.1)

[Compare
Source](https://github.com/grpc-ecosystem/go-grpc-middleware/compare/v2.0.0...v2.0.1)

#### What's Changed

- Fix outdated 'make proto' command by
[@&#8203;takp](https://github.com/takp) in
[grpc-ecosystem/go-grpc-middleware#623
- Fix linting errors by [@&#8203;takp](https://github.com/takp) in
[grpc-ecosystem/go-grpc-middleware#624
- Logging: Add missing variadic operator for fields by
[@&#8203;olivierlemasle](https://github.com/olivierlemasle) in
[grpc-ecosystem/go-grpc-middleware#629
- feat: Support extracting fields from CallMeta by
[@&#8203;fsaintjacques](https://github.com/fsaintjacques) in
[grpc-ecosystem/go-grpc-middleware#628
- Fix "make test" and "make lint" by
[@&#8203;olivierlemasle](https://github.com/olivierlemasle) in
[grpc-ecosystem/go-grpc-middleware#627
- Do not set timeout for stream initialization by
[@&#8203;DavyJohnes](https://github.com/DavyJohnes) in
[grpc-ecosystem/go-grpc-middleware#645
- Add logging option to disable fields in log entry by
[@&#8203;coleenquadros](https://github.com/coleenquadros) in
[grpc-ecosystem/go-grpc-middleware#631
- Update logging adapter docs by
[@&#8203;aboryslawski](https://github.com/aboryslawski) in
[grpc-ecosystem/go-grpc-middleware#647

#### New Contributors

- [@&#8203;takp](https://github.com/takp) made their first
contribution in
[grpc-ecosystem/go-grpc-middleware#623
- [@&#8203;olivierlemasle](https://github.com/olivierlemasle) made
their first contribution in
[grpc-ecosystem/go-grpc-middleware#629
- [@&#8203;fsaintjacques](https://github.com/fsaintjacques) made their
first contribution in
[grpc-ecosystem/go-grpc-middleware#628
- [@&#8203;DavyJohnes](https://github.com/DavyJohnes) made their first
contribution in
[grpc-ecosystem/go-grpc-middleware#645
- [@&#8203;coleenquadros](https://github.com/coleenquadros) made their
first contribution in
[grpc-ecosystem/go-grpc-middleware#631
- [@&#8203;aboryslawski](https://github.com/aboryslawski) made their
first contribution in
[grpc-ecosystem/go-grpc-middleware#647

**Full Changelog**:
grpc-ecosystem/go-grpc-middleware@v2.0.0...v2.0.1

</details>

<details>
<summary>lestrrat-go/jwx (github.com/lestrrat-go/jwx/v2)</summary>

###
[`v2.0.13`](https://github.com/lestrrat-go/jwx/releases/tag/v2.0.13)

[Compare
Source](https://github.com/lestrrat-go/jwx/compare/v2.0.12...v2.0.13)

    v2.0.13 26 Sep 2023
    [New Features]
* [jwk] jwk.Equal has been added. Please note that this is equivalent to
comparing the keys' thumbprints, therefore it does NOT take in
consideration
      non-essential fields.

    [Miscellaneous]
      * Various documentation fixes and additions.

</details>

<details>
<summary>grpc/grpc-go (google.golang.org/grpc)</summary>

### [`v1.58.2`](https://github.com/grpc/grpc-go/releases/tag/v1.58.2):
Release 1.58.2

[Compare
Source](https://github.com/grpc/grpc-go/compare/v1.58.1...v1.58.2)

### Bug Fixes

-   balancer/weighted_round_robin: fix ticker leak on update

A new ticker is created every time there is an update of addresses or
configuration, but was not properly stopped. This change stops the
ticker when it is no longer needed.

### [`v1.58.1`](https://github.com/grpc/grpc-go/releases/tag/v1.58.1):
Release 1.58.1

[Compare
Source](https://github.com/grpc/grpc-go/compare/v1.58.0...v1.58.1)

##### Bug Fixes

- grpc: fix a bug that was decrementing active RPC count too early for
streaming RPCs; leading to channel moving to IDLE even though it had
open streams
- grpc: fix a bug where transports were not being closed upon channel
entering IDLE

</details>

<details>
<summary>gotestyourself/gotestsum (gotest.tools/gotestsum)</summary>

###
[`v1.11.0`](https://github.com/gotestyourself/gotestsum/releases/tag/v1.11.0)

[Compare
Source](https://github.com/gotestyourself/gotestsum/compare/v1.10.1...v1.11.0)

#### What's Changed

- handle multiple levels in subtest regex generation by
[@&#8203;brycekahle](https://github.com/brycekahle) in
[gotestyourself/gotestsum#342
- rerun-fails: prevent extra runs when a sub-test fails by
[@&#8203;brycekahle](https://github.com/brycekahle) in
[gotestyourself/gotestsum#343
- Add note about binary test result caching by
[@&#8203;nfi-hashicorp](https://github.com/nfi-hashicorp) in
[gotestyourself/gotestsum#350
- dots-v2: hide cursor during output by
[@&#8203;howardjohn](https://github.com/howardjohn) in
[gotestyourself/gotestsum#354
- Export elapsed time to the post-run environment by
[@&#8203;afbjorklund](https://github.com/afbjorklund) in
[gotestyourself/gotestsum#360
- Include test.timeout stack trace in the junit.xml by
[@&#8203;dnephin](https://github.com/dnephin) in
[gotestyourself/gotestsum#357
- Fix dots formats with stderr by
[@&#8203;dnephin](https://github.com/dnephin) in
[gotestyourself/gotestsum#358
- Rename TESTS_ELAPSED environment variable by
[@&#8203;afbjorklund](https://github.com/afbjorklund) in
[gotestyourself/gotestsum#361
- GitHub actions format by
[@&#8203;dnephin](https://github.com/dnephin) in
[gotestyourself/gotestsum#315
- Add the time unit to elapsed time duration by
[@&#8203;afbjorklund](https://github.com/afbjorklund) in
[gotestyourself/gotestsum#363
- Add testdox format by
[@&#8203;bitfield](https://github.com/bitfield) in
[gotestyourself/gotestsum#359
- Add post-run-command notify implementation for linux by
[@&#8203;afbjorklund](https://github.com/afbjorklund) in
[gotestyourself/gotestsum#362
- dotsv2: remove jitters entirely by
[@&#8203;howardjohn](https://github.com/howardjohn) in
[gotestyourself/gotestsum#368

#### New Contributors

- [@&#8203;brycekahle](https://github.com/brycekahle) made their first
contribution in
[gotestyourself/gotestsum#342
- [@&#8203;nfi-hashicorp](https://github.com/nfi-hashicorp) made their
first contribution in
[gotestyourself/gotestsum#350
- [@&#8203;howardjohn](https://github.com/howardjohn) made their first
contribution in
[gotestyourself/gotestsum#354
- [@&#8203;afbjorklund](https://github.com/afbjorklund) made their
first contribution in
[gotestyourself/gotestsum#360
- [@&#8203;bitfield](https://github.com/bitfield) made their first
contribution in
[gotestyourself/gotestsum#359

**Full Changelog**:
gotestyourself/gotestsum@v1.10.1...v1.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cerbos/cerbos-sdk-go).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDcuMiIsInVwZGF0ZWRJblZlciI6IjM2LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brycekahle @dnephin