Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve short-verbose output for tests in CWD #61

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Improve short-verbose output for tests in CWD #61

merged 1 commit into from
Aug 25, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Aug 21, 2019

Prevents output that looks like this:

PASS ..TestHeader/readNegativeLength (0.00s)
PASS ..TestHeader/lengths/124 (0.00s)
PASS ..TestHeader/lengths/131072 (0.00s)
PASS ..TestHeader/lengths/65535 (0.00s)
PASS ..TestHeader/lengths/65537 (0.00s)
PASS ..TestHeader/lengths/65536 (0.00s)
PASS ..TestHeader/lengths/4096 (0.00s)
PASS ..TestHeader/lengths/16384 (0.00s)
PASS ..TestHeader/lengths/125 (0.00s)
PASS ..TestHeader/lengths/126 (0.00s)
PASS ..TestHeader/lengths (0.01s)
PASS ..TestHeader/fuzz (0.33s)
PASS ..TestHeader (0.00s)

We don't want the double dots if the test is in the CWD.

Prevents output that looks like this:

```
PASS ..TestHeader/readNegativeLength (0.00s)
PASS ..TestHeader/lengths/124 (0.00s)
PASS ..TestHeader/lengths/131072 (0.00s)
PASS ..TestHeader/lengths/65535 (0.00s)
PASS ..TestHeader/lengths/65537 (0.00s)
PASS ..TestHeader/lengths/65536 (0.00s)
PASS ..TestHeader/lengths/4096 (0.00s)
PASS ..TestHeader/lengths/16384 (0.00s)
PASS ..TestHeader/lengths/125 (0.00s)
PASS ..TestHeader/lengths/126 (0.00s)
PASS ..TestHeader/lengths (0.01s)
PASS ..TestHeader/fuzz (0.33s)
PASS ..TestHeader (0.00s)
```

We don't want the double dots if the test is in the CWD.
Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I agree the double dots are a bit weird.

@dnephin dnephin merged commit fc6cb58 into gotestyourself:master Aug 25, 2019
@nhooyr nhooyr deleted the better-short-verbose branch August 25, 2019 18:32
thaJeztah added a commit to thaJeztah/cli that referenced this pull request Jan 27, 2020
full diff: gotestyourself/gotestsum@v0.3.5...v0.4.0

includes:

- gotestyourself/gotestsum#59 Report if a package was cached in short formats
- gotestyourself/gotestsum#63 always colorize output unless specifically requested not to
- gotestyourself/gotestsum#61 Improve short-verbose output for tests in CWD
- gotestyourself/gotestsum#70 gotestyourself/gotestsum#70
- gotestyourself/gotestsum#73 Add short-with-failures format

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Jan 28, 2020
full diff: gotestyourself/gotestsum@v0.3.5...v0.4.0

includes:

- gotestyourself/gotestsum#59 Report if a package was cached in short formats
- gotestyourself/gotestsum#63 always colorize output unless specifically requested not to
- gotestyourself/gotestsum#61 Improve short-verbose output for tests in CWD
- gotestyourself/gotestsum#70 gotestyourself/gotestsum#70
- gotestyourself/gotestsum#73 Add short-with-failures format

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 594be50a631c4d83517be993f1ccf1bc359c1ed2
Component: cli
eiffel-fl pushed a commit to eiffel-fl/cli that referenced this pull request Jul 28, 2020
full diff: gotestyourself/gotestsum@v0.3.5...v0.4.0

includes:

- gotestyourself/gotestsum#59 Report if a package was cached in short formats
- gotestyourself/gotestsum#63 always colorize output unless specifically requested not to
- gotestyourself/gotestsum#61 Improve short-verbose output for tests in CWD
- gotestyourself/gotestsum#70 gotestyourself/gotestsum#70
- gotestyourself/gotestsum#73 Add short-with-failures format

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants