-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make start functions return a Result #568
Conversation
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 85.14% 85.22% +0.08%
==========================================
Files 111 111
Lines 5768 5774 +6
==========================================
+ Hits 4911 4921 +10
+ Misses 857 853 -4
Continue to review full report at Codecov.
|
I'm not entirely sure if it is a good idea to return a |
Good point. Probably some non-exhaustive enum that for now just stores |
Not really at the moment. |
This helps future-proofing the API. Thanks @FSMaxB for suggesting this in gotham-rs#568
Fixes #483