-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace chrono dependency by time #578
Replace chrono dependency by time #578
Conversation
There is a new contributor to chrono so they could fix chrono in future. |
Also, this change reduce complexity of |
[chrono](https://crates.io/crates/chrono) has not releases for very long time. Also, it has security error: https://rustsec.org/advisories/RUSTSEC-2020-0159.html Also, this would reduce dependencies because chrono uses very old time version so many binaries which use gotham ends with 2 versions of time linked.
Also, I suggest to add So we would use |
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
- Coverage 85.84% 85.78% -0.06%
==========================================
Files 112 112
Lines 5770 5781 +11
==========================================
+ Hits 4953 4959 +6
- Misses 817 822 +5
Continue to review full report at Codecov.
|
I was just thinking exactly that. That also removes the Invalid case as it guarantees monotonicity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
chrono has not been released for very long time (1 year already).
Also, it has security error: https://rustsec.org/advisories/RUSTSEC-2020-0159.html
Also, this would reduce dependencies because
chrono
uses very oldtime
version so many binaries which use gotham ends with 2 versions oftime
linked.