Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diesel to 2.0 #601

Merged
merged 6 commits into from
Nov 6, 2022
Merged

Update diesel to 2.0 #601

merged 6 commits into from
Nov 6, 2022

Conversation

msrd0
Copy link
Member

@msrd0 msrd0 commented Sep 2, 2022

No description provided.

dependabot bot and others added 5 commits August 30, 2022 07:15
Updates the requirements on diesel_migrations to permit the latest version.

---
updated-dependencies:
- dependency-name: diesel_migrations
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [diesel](https://github.com/diesel-rs/diesel) to permit the latest version.
- [Release notes](https://github.com/diesel-rs/diesel/releases)
- [Changelog](https://github.com/diesel-rs/diesel/blob/master/CHANGELOG.md)
- [Commits](diesel-rs/diesel@v1.4.6...v2.0.0)

---
updated-dependencies:
- dependency-name: diesel
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #601 (f086e6b) into main (84c7f08) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
+ Coverage   86.47%   86.55%   +0.07%     
==========================================
  Files         112      112              
  Lines        5871     5867       -4     
==========================================
+ Hits         5077     5078       +1     
+ Misses        794      789       -5     
Impacted Files Coverage Δ
examples/diesel/src/models.rs 33.33% <ø> (ø)
middleware/diesel/src/lib.rs 80.00% <ø> (+20.90%) ⬆️
examples/diesel/src/main.rs 87.64% <100.00%> (+0.43%) ⬆️
middleware/diesel/src/repo.rs 71.42% <100.00%> (-4.77%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@nyarly nyarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We'll need to consider semver on this

@msrd0
Copy link
Member Author

msrd0 commented Oct 6, 2022

We'll need to consider semver on this

diesel is a public dependency of the diesel middleware so this is definitely a breaking change

@svenfoo
Copy link

svenfoo commented Nov 5, 2022

Is there a plan to get this merged? Just finished porting the ORM parts of a project to diesel-2.0 only to find out that gotham_middleware_diesel isn't compatible with it yet. Would be awesome to get this merged and released soon.

@msrd0
Copy link
Member Author

msrd0 commented Nov 6, 2022

@svenfoo I think my plan was to migrate my server code to diesel 2.0 and test these changes before I merge and release them, but that never happened. Given that the changes seems rather simple and we have tests, it's probably ok to merge this anyways.

@msrd0 msrd0 merged commit b630e4e into gotham-rs:main Nov 6, 2022
@msrd0 msrd0 deleted the diesel-2.0.0 branch November 6, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants