-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update diesel to 2.0 #601
Update diesel to 2.0 #601
Conversation
Updates the requirements on diesel_migrations to permit the latest version. --- updated-dependencies: - dependency-name: diesel_migrations dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [diesel](https://github.com/diesel-rs/diesel) to permit the latest version. - [Release notes](https://github.com/diesel-rs/diesel/releases) - [Changelog](https://github.com/diesel-rs/diesel/blob/master/CHANGELOG.md) - [Commits](diesel-rs/diesel@v1.4.6...v2.0.0) --- updated-dependencies: - dependency-name: diesel dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…ions-2.0' into diesel-2.0.0
Codecov Report
@@ Coverage Diff @@
## main #601 +/- ##
==========================================
+ Coverage 86.47% 86.55% +0.07%
==========================================
Files 112 112
Lines 5871 5867 -4
==========================================
+ Hits 5077 5078 +1
+ Misses 794 789 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 We'll need to consider semver on this
diesel is a public dependency of the diesel middleware so this is definitely a breaking change |
Is there a plan to get this merged? Just finished porting the ORM parts of a project to diesel-2.0 only to find out that |
@svenfoo I think my plan was to migrate my server code to diesel 2.0 and test these changes before I merge and release them, but that never happened. Given that the changes seems rather simple and we have tests, it's probably ok to merge this anyways. |
No description provided.