Assert intentUrl is never null in dialog

gotify · Oct 2, 2023 · 567fcb4 · 567fcb4
1 parent 0c3a17c
commit 567fcb4
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/app/src/main/kotlin/com/github/gotify/messages/IntentUrlDialogActivity.kt b/app/src/main/kotlin/com/github/gotify/messages/IntentUrlDialogActivity.kt
@@ -3,9 +3,7 @@ package com.github.gotify.messages
 import android.content.Intent
 import android.net.Uri
 import android.os.Bundle
-import android.view.View
 import androidx.appcompat.app.AppCompatActivity
-import com.github.gotify.R
 import com.github.gotify.databinding.ActivityDialogIntentUrlBinding
 
 internal class IntentUrlDialogActivity : AppCompatActivity() {
@@ -14,14 +12,8 @@ internal class IntentUrlDialogActivity : AppCompatActivity() {
         setFinishOnTouchOutside(false)
         val binding = ActivityDialogIntentUrlBinding.inflate(layoutInflater)
         val intentUrl = intent.getStringExtra(EXTRA_KEY_URL)
-        binding.cancelButton.setOnClickListener { finish() }
+        assert(intentUrl != null) { "intentUrl may not be empty" }
 
-        if (intentUrl == null) {
-            binding.urlView.text = getString(R.string.action_dialog_missing)
-            binding.openButton.visibility = View.GONE
-            setContentView(binding.root)
-            return
-        }
         binding.urlView.text = intentUrl
         binding.openButton.setOnClickListener {
             finish()
@@ -31,6 +23,7 @@ internal class IntentUrlDialogActivity : AppCompatActivity() {
                 startActivity(this)
             }
         }
+        binding.cancelButton.setOnClickListener { finish() }
         setContentView(binding.root)
     }