Add ability to click on the notification to open url

[vaisest]

Example video: https://i.vgy.me/Kfzqx9.mp4

I think this should be fairly easy to implement, but a nice feature to have.

[eternal-flame-AD]

Sorry but I can't access the video you have sent, but I think this might be a duplicate of gotify/server#65.

[vaisest]

I don't think it is a duplicate. I only mean supporting launching a browser when tapping on the notification, and I don't think it requires a separate URL parameter as the URL can be parsed from the message content.

I made a wonky patch for myself: Turtvaiz/android@6d55729

Also, a rehosted video

[eternal-flame-AD]

Okay, I got what you meant, but considering we have decided to implement actionable notifications through the newly added "extra" property in the message model in the future, the new mechanism would be able to resolve this problem, so I don't see the particular need for this. I also don't really like searching through the message content and take whatever looks like a URL and use that link as the default behavior for viewing the notification, as makes software behavior rather unpredictable.

@jmattheis what do you think?

[eternal-flame-AD]

Also, as gotify aims to be both easy to use and understand, please excuse that we usually do not accept feature requests that might in some way confuse other users. However, it is really happy to see that you have came up with your own solution, and we really recommend power users to make modifications to accomodate their own needs.

[jmattheis]

I also think that this should be done via an extra property. IMO things should be done explicit.

[mzoeller]

Would you accept a pull request where an extra called "client::click" would be interpreted by the android client?

"extras": {
        "client::click": {
            "url": "somescheme://some/link#4"
        }
    }

Or is there a better way/more general way to define actionable things?

[jmattheis]

Hey @mzoeller,

sure thing, pull requests are welcome :D.

But let's define the scheme for the extras, so that is extensible and future proof. In gotify/server#151 (comment) we already have web::notification and android::notification, so I'd say we use client::notification for things that can be supported on both android and web ui.

IMO click should be an object, because in the future there may be something like javascriptEval that should be executed on click.

{
  "extras": {
    "client::notification": {
      "click": { 
        "url": "https://gotify.net"
      }
    }
  }
}

[mzoeller]

I've submitted a pull request: #91