Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for opening urls when clicking on notifications. #91

Merged
merged 3 commits into from
Feb 5, 2020
Merged

Add support for opening urls when clicking on notifications. #91

merged 3 commits into from
Feb 5, 2020

Conversation

mzoeller
Copy link
Contributor

@mzoeller mzoeller commented Feb 3, 2020

No description provided.

Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mzoeller,

Thanks for your contribution. I've one remark about the handling of malformed extras, see subcomments.

@mzoeller
Copy link
Contributor Author

mzoeller commented Feb 3, 2020

Agreed! Thanks for the input. I have updated the pr.

Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll test/merge it later today and then create a release for it.

@jmattheis jmattheis merged commit a4cbd88 into gotify:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants