Pushing, sharing messages prototype #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
requested changes
Jul 10, 2020
app/src/main/java/com/github/gotify/messages/MessagesActivity.java
Outdated
Show resolved
Hide resolved
|
Hey @jmattheis , Thanks for the fast review! And sorry for my messy github usage, still learning :)
|
|
I've made some more changes to use material ui text views. (I've made the changes because I didn't knew exactly what I wanted, so I tinkered a little). Also, I cleaned up some minor stuff. Can you look over the changes I made? |
|
Checked, looks great! :) |
|
Great. I've cleaned up the commit history to remove the pr commits. Thanks for your contribution! |
jmattheis
approved these changes
Jul 12, 2020
This was referenced Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
I've finished what @rorpage started implementing - message pushing/sharing functionality.
Still it would be great to get input about naming, and general order of the code.
Hope we can fix these fast and merge into master :)