Notification improvements for android 8+ #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schwma
commented
Nov 8, 2018
schwma
commented
- Fix persistent notification causing vibration and audio alerts (for example when loosing connection to server)
- Allow message notifications to pop up as heads-up notifications
- Add LED light to message notifications
- Prevent duplicate notification sounds from message group notification
- Add message notification accent color (set to colorPrimary)
jmattheis
requested changes
Nov 8, 2018
There was a problem hiding this comment.
Thanks for your contribution, the commits are structured really well and are easy to understand!
Most of the stuff should already be configurable in the android notification settings for the application (right?) tho the used defaults weren't that good. So good change.
I've only one nitpick. The foreground notification doesn't have the blue-ish color that the other notifications have.
jmattheis
approved these changes
Nov 9, 2018
|
Fixed my nitpick in #20 |
|
Thanks for the merge! Thats true! However, some notification settings can't be changed on stock Android and most default ROMs without installing additional apps. For example I can't adjust the notification LED settings on my device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.