Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Loose app filter on screen rotation #208

Merged
merged 2 commits into from
Jan 30, 2022
Merged

Bugfix: Loose app filter on screen rotation #208

merged 2 commits into from
Jan 30, 2022

Conversation

Sternagfonkel
Copy link
Contributor

Created a view model for the messages activity. It holds the objects which provide data to the view. The view model is not destroyed and recreated on screen rotation, so it is also used to hold the information about the selected app and therefore fixes #207. As well this should provide a slight performance improvement on screen rotation.

Markus added 2 commits January 22, 2022 20:30
View model provides data objects for messages activity and is not destroyed and recreated on screen rotation.
So screen rotation should be a bit more faster.
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your 4th pull request!

@jmattheis jmattheis merged commit 09ccd4d into gotify:master Jan 30, 2022
@Sternagfonkel Sternagfonkel deleted the bugfix/app-filter-screen-rotation_#207 branch January 31, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Screen rotation removes App filter
2 participants