Fix blocking permission requests #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
reviewed
Oct 2, 2023
app/src/main/kotlin/com/github/gotify/init/InitializationActivity.kt
Outdated
Show resolved
Hide resolved
|
We have that weird behaviour again that it does not recognize Kotlin functions. Edit: Downgrading Kotlin fixed it once again |
cyb3rko
force-pushed
the
fix-permission-blocking
branch
from
7e24579
to
ba04033
Compare
jmattheis
previously approved these changes
Oct 3, 2023
app/src/main/kotlin/com/github/gotify/init/InitializationActivity.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've realized that this line
android/app/src/main/kotlin/com/github/gotify/init/InitializationActivity.kt
Line 65 in 310b73a
is blocking the UI thread until the condition is true. Because permission requests take some seconds the app is blocking for several seconds, even leading to possible app crashes.
The solution is canceling the splashScreen when requesting permissions and showing the previous "splash screen layout".
Tested on Android 13 (33) and 14 (34).