Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to tinylog #317

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Migrate to tinylog #317

merged 3 commits into from
Oct 8, 2023

Conversation

jmattheis
Copy link
Member

@jmattheis jmattheis commented Oct 7, 2023

This change migrates from hyperlog to tinylog. Tinylog allows us to persist log messages on disk mhich should improve debugging the app.

app/build.gradle Outdated Show resolved Hide resolved
@cyb3rko
Copy link
Contributor

cyb3rko commented Oct 7, 2023

What do you mean that "Tinylog allows us to persist log messages on disk"?
Am I wrong that Hyperlog also had persistent storage of logs?

But I clearly see that Tinylog is better in many ways

@cyb3rko
Copy link
Contributor

cyb3rko commented Oct 7, 2023

And I've just realized that I should have implemented some logging in my PRs.
But probably this is the wrong PR to fix this as well...

@jmattheis
Copy link
Member Author

What do you mean that "Tinylog allows us to persist log messages on disk"?
Am I wrong that Hyperlog also had persistent storage of logs?

Ahh you're right. I was assuming it did not because the log did disappear for me a couple of times after crashes.

And I've just realized that I should have implemented some logging in my PRs.
But probably this is the wrong PR to fix this as well...

Yeah, but I'd say this is only nice to have. The logging mainly exists for debugging the WebSocketService because users misconfigure their reverse proxy and then this connection is buggy.

@jmattheis
Copy link
Member Author

Do you want to be involved in more PRs to this project?

@cyb3rko
Copy link
Contributor

cyb3rko commented Oct 8, 2023

Sure, why not.
In the next few months I will be working all day, but either in the evenings or on the weekends I will always find some time for open source projects :)

@jmattheis jmattheis merged commit 5e67cc8 into master Oct 8, 2023
3 checks passed
@jmattheis jmattheis deleted the log branch October 8, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants