Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Gotify WebSocketService on boot completed #32

Merged
merged 2 commits into from
Dec 22, 2018
Merged

Start Gotify WebSocketService on boot completed #32

merged 2 commits into from
Dec 22, 2018

Conversation

schwma
Copy link
Contributor

@schwma schwma commented Dec 12, 2018

Start the Gotify WebSocketService on receiving boot completed broadcast if a Gotify user token is saved in the settings.

Let me know if the BootCompletedReceiver should implement any authorization checks like the InitializationActivity does before starting the service.

(Closes: #25)

@schwma schwma changed the title Start Gotify WebSocketService on boot completed (closes #25) Start Gotify WebSocketService on boot completed Dec 12, 2018
@jmattheis jmattheis self-requested a review December 12, 2018 20:28
@jmattheis
Copy link
Member

Thanks! I'll test this PR hopefully later this week, I'm currently on a work trip where I don't have access to my android dev environment.

@schwma
Copy link
Contributor Author

schwma commented Dec 12, 2018

Ah of course, no worries. Take your time! :)

Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks.

@jmattheis jmattheis merged commit d9c3b60 into gotify:master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants