Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major rewrite #12

Merged
merged 63 commits into from
Jan 21, 2024
Merged

Major rewrite #12

merged 63 commits into from
Jan 21, 2024

Conversation

heucuva
Copy link
Contributor

@heucuva heucuva commented Jan 21, 2024

Major Rewrite

  • Replaced (mostly-)dedicated playback engines for each format with a single engine that can be configured to supply all the feature support and quirks those formats want.
    • The new engine ("machine") can be ticked without generating sample output, which is very handy when debugging.
    • This new engine fixes a myriad issues with playback of notes.
  • Replaced the old tracing system with a more information-dense tracing system.

Added

  • Added extensible support for new filters and effects.
  • Added "quirks" support for formats so they can dictate their special behaviors that other formats don't have (or want).

@heucuva
Update to go 1.21
5b14bf9 
- update dependencies
- some clean up use of generics
@heucuva
Simplify pattern processing
95a589f
@heucuva
simplify playback system a little
844c8ea
@heucuva
clean up more playback object duplication
82f90aa 
- fix issue with IT sample speed calculations
@heucuva
Fix period/frequency calculations
0ed614c
@heucuva
update go.mod
d01d563
@heucuva
reduce generics usages
2645d2c 
- simplify period calculations
- reuse period patterns
- require derivations of period types
@heucuva
reduce complexity of period calculations
524b8ea 
- less direct playback structs
- simpler playback management
@heucuva
effect cleanup
101e1e8
@heucuva
spacing
0e64e52
@heucuva
drastically simplify period considerations
5b894e3
@heucuva
simplify porta of periods
c8af97c
@heucuva
missed in last checkin
0433069
@heucuva
fix test and update go.mod
c90073a
@heucuva
extra simplification of period converters
29866e0
@heucuva
clean up voice cloning
89c447a 
- reenable fadeout code
@heucuva
clean up format field names
30d81cd
@heucuva
clean up type conversions for channel data
0c4148c 
- split channel processing out to format
@heucuva
clean up envelope code
7f4ea9b 
- fix issue were instrument envelopes might not get setup properly
@heucuva
Fix filter envelope
de71b60
@heucuva
better fix for pitch filter
79d3f38
@heucuva
better calculation of filter value
3bf62a2
@heucuva
Fix for s3m/mod envelope crash
422c290
@heucuva
Support mod fine-panning
da045fb 
- also stub out s3m surround support
@heucuva
s3m playback cleanup
8c477b0
@heucuva
first pass on cleaning up interfaces
e90e338
@heucuva
further cleanup
4d2177e
@heucuva
rework tracing to make issues more visible
8e31e41
@heucuva
round 1 of playback cleanup
8155ef6
@heucuva
round 2 of playback cleanup
c749129
@heucuva
past note cleanup, voice cleanup
7070a70
@heucuva
hook up new note actions flag
9dd2d0a
@heucuva
move frequency type to its own package
6a1e5e8 
- reduces issue with cycle detection misidentifying period package
@heucuva
consistent package imports
f5de2c9
@heucuva
make format voices understand instruments instead of generic configs
cdc86fa 
- also fix mixing overload on virtual outputs
@heucuva
Drastically simpler patterns and rows
d945fea
@heucuva
Clean up settings object
5388f66
@heucuva
pipe opl2 code back in
f5f035c
@heucuva
fix ordering
2907fec
@heucuva
fix for runaway past notes
4fc3866
@heucuva
fix vol0 opt code
91c7806 
- fix s3m/mod portamentos
- fix channel instructions sticking between rows
@heucuva
safer amiga limits
cac239b
@heucuva
fix extra spammative new note actions
7eb270d
@heucuva
produce multiple ticks worth of output in allotted time
500042d
@heucuva
support s3m quirk of porta from final period
fd24f93 
- implement octave shift for amiga periods (xm/s3m)
@heucuva
Fix OPL2 deferred keyon and base freq
69957cc
@heucuva
reintegrate play until order/row support
70f7c10 
- fix up some quirks
- clean up period converters
@heucuva
major cleanup
6567270
@heucuva
cleanup and more formalization
a109987
@heucuva
reduce complexity of xm instrument mapping
e952940
@heucuva
simplify and clean up, fix pcm format detector
422589e
@heucuva
fix instrument mapping and semitone remap
2325489
@heucuva
todo cleanup
f6d03b7
@heucuva
final todo work
4be63e4
@heucuva
clean up issues with opl2 linking, update gomod
ce41a19
@heucuva
fix autovibrato errors
83be144
@heucuva
final cleanups
84b0769
@heucuva
clean up generation interface
4094620
@heucuva heucuva merged commit 75416c9 into gotracker:main Jan 21, 2024
@heucuva heucuva deleted the cleanup-generics branch January 21, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@heucuva