Skip to content

Commit

Permalink
Report error explicitly if card activities file is empty
Browse files Browse the repository at this point in the history
  • Loading branch information
gottenheim committed Jul 9, 2023
1 parent 497ab85 commit 93431cf
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
3 changes: 2 additions & 1 deletion core/card/card_activity_deserializer.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package card

import (
"bytes"
"fmt"
"time"

"github.com/gottenheim/ariadne/libraries/config"
Expand All @@ -11,7 +12,7 @@ func DeserializeCardActivityChain(activitiesBinary []byte) (CardActivity, error)
cfg, err := config.FromYamlReader(bytes.NewReader(activitiesBinary))

if err != nil {
return nil, err
return nil, fmt.Errorf("Failed to read card activities: %v", err)
}

cardActivitiesModel := &CardActivitiesModel{}
Expand Down
3 changes: 2 additions & 1 deletion details/fs_repo/answered_card_emitter.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package fs_repo

import (
"context"
"fmt"
"io"
"os"
"path/filepath"
Expand Down Expand Up @@ -48,7 +49,7 @@ func (e *fileCardEmitter) Run(ctx context.Context, output chan<- card.BriefCard)
cardActivities, err := e.cardRepo.ReadCardActivities(cardDir)

if err != nil {
return err
return fmt.Errorf("failed to read activities for card %v", cardDir)
}

section, entry := e.cardRepo.GetCardPathSection(cardDir), e.cardRepo.GetCardPathEntry(cardDir)
Expand Down
4 changes: 1 addition & 3 deletions use_cases/study_cards_session.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,5 @@ func NewStudyCardsSession(timeSource datetime.TimeSource, cardRepo card.CardRepo
func (s *StudyCardsSession) Run(cardEmitter pipeline.Emitter[card.BriefCard], config *study.DailyCardsConfig) error {
session := study.NewSession(s.timeSource, s.cardRepo, s.userInteractor)

session.Run(config, cardEmitter)

return nil
return session.Run(config, cardEmitter)
}

0 comments on commit 93431cf

Please sign in to comment.