Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket Auth #505

Closed
JoobyPM opened this issue Oct 12, 2018 · 5 comments
Closed

WebSocket Auth #505

JoobyPM opened this issue Oct 12, 2018 · 5 comments

Comments

@JoobyPM
Copy link

JoobyPM commented Oct 12, 2018

Hi @gotthardp ,
As I understood there is no authentification for WebSocket connectors, is it true?
Could you please suggest – do you have in plans implementation of Basic Auth for WebSocket?

@gotthardp
Copy link
Owner

Hello. The WS authentication is tricky and therefore is not implemented (yet).
As I understood e.g. here the libraries support HTTP Basic only. The problem is the server doesn't store plaintext passwords (for security reasons), so the question is where to take the password from.

One solution would be to take the password from the connector configuration. The drawback would be that you could specify only one username-password per connection, and that it would be separated from the standard server users.

@JoobyPM
Copy link
Author

JoobyPM commented Oct 12, 2018

Thank you for the prompt reply.
It will be great if you can implement that feature.

@gotthardp
Copy link
Owner

I just implemented something (without testing). Please give it a try and let me know if it doesn't work.

@JoobyPM
Copy link
Author

JoobyPM commented Oct 12, 2018

Many thanks for that enhancement.
I've builded and tested - it's working perfectly with HTTP Basic for WebSocket.

@gotthardp
Copy link
Owner

Cool. Thanks for testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants