-
Notifications
You must be signed in to change notification settings - Fork 787
Handle ExportNamedDeclarations #507
Handle ExportNamedDeclarations #507
Conversation
You change does not pass the |
How about this? |
Sorry man, I'm totally slammed this week - will get to it in 4-6 days. |
No worries. I'll get out of your hair. 😉 |
+1 |
} catch (ex) { | ||
console.error('ES6 feature [' + feature + '] is not available in this environment'); | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of making the environment detection "pass", could you rather not just remove the conditional check in test-es6-export.js
that tries to do environment detection?
1031f76
to
b6a2a3a
Compare
b6a2a3a
to
d828255
Compare
Sorry for the delay. I've addressed all the issues. Let's get these changes in! 😄 |
I just ran into this exact problem and found this PR. Skimming over the requested changes it looks good to me. Hope this will be merged soon, because this prevents code coverage for es6 environments. |
@gotwarlost Hi. When we can wait a release? |
Should this enable this to be instrument-able now? export default {
...
} I manually upgrade the dependency in https://github.com/deepsweet/babel-istanbul-loader to use babel-istanbul@0.11.x but I'm still getting unexpected token hitting an export default where an exports = works. |
Istanbul currently doesn't handle
export var ...
, and throws:This PR attempts to rectify this.