This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
correct ansi colors for 16 colors environments #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
Actually, there is a small difference between the old and new code. If an Could you modify the code so that the old behavior of not modifying the string when an unknown class name is passed, is maintained? |
|
I've updated the PR. Thanks for the review! |
|
Available in istanbul@0.4.3 - sorry for the delay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colors were used from the non-standard 90-97 ansi range. Travis, and some other terminals, does not support these and so show white text. With this change the colors are visible again.
Proof at the travis logs of this PR https://travis-ci.org/gotwarlost/istanbul/jobs/117557241#L3662