fix: add modules from base image #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusufhm
changed the title
fixes GOVCMS-7732
This reverts commit a2dc88d0d819ab907e95b8e88c6840be98151f76.
fixes GOVCMS-7732
yusufhm
force-pushed
the
fix/paas-missing-module
branch
from
f870202 to
a15e78f
Compare
steveworley
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes GOVCMS-7732
Required govcms modules are added to
/app/web/sites/all(see here), but the PaaS image has traditionally been removing the/appdirectory.It seems like the base image is now leaner as per the comment and we can safely get rid of the line.Added a line to copy the modules from the base image.