Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skin: use custom favicon PNG #4

Closed
wants to merge 12 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
language: node_js
node_js:
- 8
- node
cache:
yarn: true
directories:
- skin/node_modules
before_install:
- curl -o- -L https://yarnpkg.com/install.sh | bash
- export PATH="$HOME/.yarn/bin:$PATH"
script:
- 'if [ $TEST_SUITE = "skin" ]; then skin/ci/test.sh; fi'
env:
matrix:
- TEST_SUITE=skin
12 changes: 12 additions & 0 deletions skin/ci/test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/usr/bin/env sh

set -eu

# Start in skin/
cd "$(dirname "$0")/.."

yarn install

yarn prettier-check

yarn test
Binary file added skin/img/favicon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions skin/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import React from "react";

import "./img/favicon.png";

import InfoActivities from "../../components/info_activities.jsx";
import InfoEnvironments from "../../components/info_environments.jsx";
import InfoSandbox from "../../components/info_sandbox.jsx";
Expand Down
7 changes: 5 additions & 2 deletions skin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@
"name": "console-skin",
"version": "1.0.0",
"dependencies": {
"prettier": "^1.7.4"
"prettier": "^1.7.4",
"react-scripts": "^1.0.14"
},
"scripts": {
"prettier": "prettier --write \"**/*.{js,json}\""
"prettier": "prettier --write \"**/*.{js,json}\"",
"prettier-check": "prettier --list-different \"**/*.{js,json}\"",
"test": "react-scripts test --env=jsdom"
}
}
2 changes: 1 addition & 1 deletion skin/templates/web/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@


<link rel="stylesheet" type="text/css" href="assets/style.css">
<link rel="shortcut icon" type="image/png" href="assets/img/favicon.ico" />
<link rel="icon" type="image/png" sizes="96x96" href="assets/img/favicon.png">

<title>cloud.gov.au console</title>
</head>
Expand Down
Loading