Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bridge levels for bright style #108

Merged
merged 2 commits into from
May 26, 2024
Merged

Conversation

AndriusGeo
Copy link
Contributor

@AndriusGeo AndriusGeo commented May 25, 2024

This PR fixes two major problems with Bright style:

  • To fix styling issues at 3-level junctions, a level 2 bridge representation has been added;
  • Bridges have been added for minor roads, which were originally missing in the Bright style (strange, because this style has, for example, a bridge for a tracks, but side roads were not included).

Before:
image

After:
image

Before:
image

After:
image

P.S. Positron style does not use multiple levels at all.

Copy link

[m[0m0:05:50 DEB [archive] - Tile stats:
[m[0m0:05:50 DEB [archive] - Biggest tiles (gzipped)
1. 14/9280/5189 (64k) http://localhost:8080/styles/bright/#14.5/54.9082/23.91724 (building:50k)
2. 14/9281/5192 (60k) http://localhost:8080/styles/bright/#14.5/54.87028/23.93921 (building:48k)
3. 9/292/161 (58k) http://localhost:8080/styles/bright/#9.5/55.17836/25.66406 (landcover:37k)
4. 14/9278/5196 (57k) http://localhost:8080/styles/bright/#14.5/54.81968/23.87329 (building:48k)
5. 9/292/160 (57k) http://localhost:8080/styles/bright/#9.5/55.57784/25.66406 (landcover:35k)
6. 9/287/159 (55k) http://localhost:8080/styles/bright/#9.5/55.9733/22.14844 (landcover:33k)
7. 9/291/162 (54k) http://localhost:8080/styles/bright/#9.5/54.77484/24.96094 (landcover:28k)
8. 14/9263/5117 (54k) http://localhost:8080/styles/bright/#14.5/55.80746/23.5437 (building:39k)
9. 8/145/81 (53k) http://localhost:8080/styles/bright/#8.5/54.57002/24.60938 (landcover:32k)
10. 14/9162/5132 (53k) http://localhost:8080/styles/bright/#14.5/55.62179/21.32446 (building:42k)
[m[0m0:05:50 DEB [archive] - Max tile sizes
                      z0    z1    z2    z3    z4    z5    z6    z7    z8    z9   z10   z11   z12   z13   z14   all
           boundary  382   448   565   833   894  3.7k  5.8k  5.3k  3.2k  2.5k  1.8k  2.2k  1.7k  1.6k  1.4k  5.8k
              place  531   453   453   453   911   911  4.8k  4.8k  3.8k  1.4k   591   551  7.3k  2.6k   974  7.3k
     transportation    0     0   491   753  3.3k  5.6k  9.9k   13k   19k   10k  8.9k   13k   14k   10k  7.1k   19k
              water    0     0    61    70    98   261    2k  5.2k   14k   15k   11k  9.6k  7.4k  5.2k  6.2k   15k
          landcover    0     0     0     0     0     0   879   18k   32k   37k   27k   24k   26k   19k   15k   37k
         water_name    0     0     0     0     0     0   165   180   200   225   267   800   758    1k  1.9k  1.9k
            landuse    0     0     0     0     0     0     0    99   144   364  5.5k   17k   12k   10k   10k   17k
transportation_name    0     0     0     0     0     0     0  2.5k  1.3k  2.3k  1.1k  1.7k  5.6k  2.8k  7.5k  7.5k
    aerodrome_label    0     0     0     0     0     0     0     0   284   209   271   271   209   209   182   284
           waterway    0     0     0     0     0     0     0     0     0   27k   14k   11k  8.5k  5.5k  3.4k   27k
            aeroway    0     0     0     0     0     0     0     0     0     0  1.2k  1.5k  1.3k  1.8k  1.5k  1.8k
               park    0     0     0     0     0     0     0     0     0     0     0     0  9.8k  6.1k  3.5k  9.8k
                poi    0     0     0     0     0     0     0     0     0     0     0     0  6.1k  2.8k  1.4k  6.1k
           building    0     0     0     0     0     0     0     0     0     0     0     0     0   33k   50k   50k
 forest_compartment    0     0     0     0     0     0     0     0     0     0     0     0     0  5.7k  4.3k  5.7k
        housenumber    0     0     0     0     0     0     0     0     0     0     0     0     0     0   17k   17k
              power    0     0     0     0     0     0     0     0     0     0     0     0     0     0   592   592
          full tile  913   901  1.5k  2.1k  5.1k   10k   23k   49k   67k   76k   49k   44k   60k   63k   83k   83k
            gzipped  546   577    1k  1.5k  3.8k  7.8k   17k   37k   53k   58k   39k   36k   42k   50k   64k   64k
[m[0m0:05:50 DEB [archive] -    Max tile: 83k (gzipped: 64k)
[m[0m0:05:50 DEB [archive] -    Avg tile: 21k (gzipped: 17k) using weighted average based on OSM traffic
[m[0m0:05:50 DEB [archive] -     # tiles: 51,889
[m[0m0:05:50 DEB [archive] -  # features: 14,012,730
[m[0m0:05:50 INF [archive] - Finished in 1m54s cpu:7m29s gc:4s avg:3.9
[m[0m0:05:50 INF [archive] -   read    1x(1% 1s wait:1m43s done:10s)
[m[0m0:05:50 INF [archive] -   encode  4x(88% 1m40s done:1s)
[m[0m0:05:50 INF [archive] -   stats   1x(0% 0.5s wait:1m53s done:1s)
[m[0m0:05:50 INF [archive] -   write   1x(1% 0.9s wait:1m52s done:1s)
[m[0m0:05:50 INF - Finished in 5m50s cpu:20m9s gc:7s avg:3.5
[m[0m0:05:50 INF - FINISHED!
[m[0m0:05:50 INF - 
[m[0m0:05:50 INF - ----------------------------------------
[m[0m0:05:50 INF - data errors:
[m[0m0:05:50 INF - render_snap_fix_input137,080
[m[0m0:05:50 INF - merge_snap_fix_input38
[m[0m0:05:50 INF - ----------------------------------------
[m[0m0:05:50 INF - overall 5m50s cpu:20m9s gc:7s avg:3.5
[m[0m0:05:50 INF - grpk    3m40s cpu:12m6s gc:3s avg:3.3
[m[0m0:05:50 INF -   read     1x(36% 1m19s wait:2m25s done:2s)
[m[0m0:05:50 INF -   process  3x(88% 3m15s wait:11s done:2s)
[m[0m0:05:50 INF -   write    1x(2% 4s wait:3m34s done:2s)
[m[0m0:05:50 INF - ar      8s cpu:17s avg:2.2
[m[0m0:05:50 INF -   read     1x(95% 7s)
[m[0m0:05:50 INF -   process  3x(40% 3s wait:6s)
[m[0m0:05:50 INF -   write    1x(3% 0.2s wait:7s)
[m[0m0:05:50 INF - sort    6s cpu:15s avg:2.4
[m[0m0:05:50 INF -   worker  1x(48% 3s wait:3s)
[m[0m0:05:50 INF - archive 1m54s cpu:7m29s gc:4s avg:3.9
[m[0m0:05:50 INF -   read    1x(1% 1s wait:1m43s done:10s)
[m[0m0:05:50 INF -   encode  4x(88% 1m40s done:1s)
[m[0m0:05:50 INF -   stats   1x(0% 0.5s wait:1m53s done:1s)
[m[0m0:05:50 INF -   write   1x(1% 0.9s wait:1m52s done:1s)
[m[0m0:05:50 INF - ----------------------------------------
[m[0m0:05:50 INF - archive330MB
[m[0m0:05:50 INF - features919MB
[m

Copy link
Member

@vycius vycius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing!

I highly recommend submitting a pull request for the bridges over minor roads issue to OpenMapTiles/osm-bright-gl-style. It definitely seems like a bug that needs fixing.

@vycius vycius merged commit 60cfec5 into main May 26, 2024
10 checks passed
@vycius vycius deleted the update-bridge-levels-for-style branch May 26, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants