Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change meadow class and add parks #44

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Conversation

AndriusGeo
Copy link
Contributor

@AndriusGeo AndriusGeo commented Apr 13, 2024

Add wood and park grass classes for forest and squares in cities

Before:
image

After:
image

This change also add some more effects in smaller scales where city parks are

Before:
image
image
After:
image
image

@AndriusGeo AndriusGeo requested a review from vycius April 13, 2024 15:22
Copy link
Member

@vycius vycius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@@ -23,16 +23,17 @@ public class Landcover implements ForwardingProfile.FeaturePostProcessor, Forwar

@Override
public void processFeature(SourceFeature sf, FeatureCollector features) {
if (sf.getSource().equals(Source.GRPK) && sf.getSourceLayer().startsWith(Layer.GRPK_PLOTAI_PREFIX) && sf.canBePolygon()) {
if (sf.getSource().equals(Source.GRPK) && (sf.getSourceLayer().startsWith(Layer.GRPK_PLOTAI_PREFIX) || sf.getSourceLayer().startsWith(Layer.GRPK_VIETOV_P))&& sf.canBePolygon()) {
Copy link
Member

@vycius vycius Apr 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one VIETOV_P layer. Consider replacing sf.getSourceLayer().startsWith(Layer.GRPK_VIETOV_P) with sf.getSourceLayer().equals(Layer.GRPK_VIETOV_P).

@AndriusGeo AndriusGeo merged commit 89c928f into main Apr 13, 2024
6 checks passed
@AndriusGeo AndriusGeo deleted the fix-wood-forest-classes branch April 13, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants