Skip to content

Commit

Permalink
BAU: Prevent Sass mixed declaration warnings
Browse files Browse the repository at this point in the history
The CSS Working Group has changed the way CSS handles declarations
mixed with nested rules. Sass has been updated to reflect this change
and any declarations that appear after nested rules are deprecated
in Dart Sass distributions > 1.77.7 (See [^1] below)

As a result of this we have been seeing multiple deprecation warnings
when compiling our Sass. This commit simply changes the code so that
a nested rule appears after declarations in the same block.

[^1] https://sass-lang.com/documentation/breaking-changes/mixed-decls/
  • Loading branch information
gtvj committed Sep 23, 2024
1 parent b79dee3 commit 1dfcb45
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/assets/scss/application.scss
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@
}

.govuk-show-password__toggle {
@include govuk-font(19);
z-index: 0;
display: table-cell; // IE fallback
padding: govuk-spacing(1) govuk-spacing(3);
Expand All @@ -146,6 +145,8 @@
white-space: nowrap;
cursor: pointer;

@include govuk-font(19);

@include govuk-media-query($until: mobile) {
padding: govuk-spacing(1);
width: 100%;
Expand Down

0 comments on commit 1dfcb45

Please sign in to comment.