Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAU: Use eslint and prettier from node_modules #1820

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

whi-tw
Copy link
Contributor

@whi-tw whi-tw commented Jul 11, 2024

What

Rather than managing dependencies twice, just use the local node_modules for pre-commit depdencies. This will require a yarn install before running it for the first time - This has been added to the pre-commit.yml workflow

Additionally, don't run pre-commit for dependabot PRs.

How to review

  • Code review

@whi-tw whi-tw requested review from a team as code owners July 11, 2024 14:00
@whi-tw whi-tw force-pushed the BAU/fix-pre-commit branch 2 times, most recently from 0be40ba to f34e37b Compare July 11, 2024 14:05
Copy link

sonarcloud bot commented Jul 11, 2024

@whi-tw whi-tw merged commit 53cb0a0 into main Jul 11, 2024
5 checks passed
@whi-tw whi-tw deleted the BAU/fix-pre-commit branch July 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants