BAU: Prevent Sass mixed declaration warnings #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSS Working Group has changed the way CSS handles declarations mixed with nested rules. Sass has been updated to reflect this change and any declarations that appear after nested rules are deprecated in Dart Sass distributions > 1.77.7 (See [^1] below) As a result of this we have been seeing multiple deprecation warnings when compiling our Sass. This commit simply changes the code so that a nested rule appears after declarations in the same block. [^1] https://sass-lang.com/documentation/breaking-changes/mixed-decls/
|
BeckaL
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The CSS Working Group has changed the way CSS handles declarations mixed with nested rules. Sass has been updated to reflect this change and any declarations that appear after nested rules are deprecated in Dart Sass distributions > 1.77.7 (See Sass documentation)
As a result of this we have been seeing multiple deprecation warnings when compiling our Sass.
This commit simply changes the code in a block that is specific to the password entry component so that a nested rule appears after declarations in the same block.
Screenshot after change
How to review