-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DFC-661]: Remove the Beta Banner from Strategic App view #2117
[DFC-661]: Remove the Beta Banner from Strategic App view #2117
Conversation
Internal sign off done - works locally as expected. Ready for handover to auth team |
Tested and verified locally - LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SophiaDWokoma 👋🏽
Thank you for your work on this. I haven't yet reviewed the code or PR, but it seems but it seems some of the comments I've provided on #2114 (review) might be relevant here too. Would you be OK to look into these?
Hi @SophiaDWokoma - thanks for your recent comment (and apologies that I'd started the thread in the wrong PR, I'd been doing a lot of context switching). I have moved the comment to the right place now and provided a bit more context. We tend to avoid using "squash and merge" because it loses information that might be useful to future developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SophiaDWokoma - I've made just a couple of suggestions on this PR relating to the way tests are described.
Like #2114, my sense is that the commits for this PR would benefit from being brought in line with The GDS Way - Working with Git guidance that I shared previously. There are four commits currently and, given this is a single step (i.e. hiding the phase banner), I'd have thought this would would probably be appropriate to include in a single commit.
Ok I have used fixup to clean up the commit history and combine the commits. |
c415dd9
to
6c06f90
Compare
6c06f90
to
c663cd5
Compare
Quality Gate passedIssues Measures |
What
Implemented conditional rendering of the beta banner in the base.njk file to ensure it is only visible in web view. Also, added integration tests to verify the functionality.
How to review
Checklist
Related PRs
DFC-661