Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSREDEV-1817: Add Python upload action #17

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

beca-galliano
Copy link
Contributor

@beca-galliano beca-galliano commented Oct 1, 2024

Description

Adds Python version of the upload action which currently works exactly as the bash upload action.

Next steps for this work is to refactor, improve and test.

Ticket number

PSREDEV-1817

Test evidence

Tested using the sam-demo-app2
https://github.com/govuk-one-login/devplatform-demo-sam-app/actions/runs/11068201949/job/30753146311
Screenshot 2024-10-01 at 18 55 21

GitHub Action Releases

We follow recommended best practices for releasing new versions of the action.

Non-breaking Chanages:

Release a new minor or patch version as appropriate. Then, update the base major version release (and any minor versions)
to point to this latest commit. For example, if the latest major release is v2 and you have added a non-breaking feature,
release v2.1.0 and point v2 to the same commit as v2.1.0.

NOTE: Dependabot does not pick up and raise PRs for PATCH versions (i.e v3.8.1), please nofity teams in the relevant slack channels.

Breaking Changes:

Release a new major version as normal following semantic versioning.

Checklist

  • Is my change backwards compatible? Please include evidence

  • I have installed and run pre-commit

  • I have tested this and added output to Jira
    Comment:

  • Automated tests added
    Comment:

  • Documentation added (link)
    Comment:

  • Delete any new stacks created for this ticket
    Comment:

Co-authored by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant