Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large font-size on selected days in 9.3.0 #2580

Closed
staaky opened this issue Nov 11, 2024 · 3 comments · Fixed by #2588
Closed

Large font-size on selected days in 9.3.0 #2580

staaky opened this issue Nov 11, 2024 · 3 comments · Fixed by #2588
Assignees

Comments

@staaky
Copy link

staaky commented Nov 11, 2024

In 9.3.0 there's a font-size: large on .rdp-selected, it makes the selected days too big (see screenshot).

.rdp-selected {
font-weight: bold;
font-size: large;
}

Probably overlooked because the website has overrides that mask the problem.

I can replicate it on daypicker.dev by disabling these in devtools:

.rdp-day button {
font-size: 1rem !important;
}
.rdp-weekday {
font-size: 0.75rem !important;
}

.docusaurus-reset table.rdp-month_grid td {
border: revert;
padding: revert;
font-size: 1rem;
}

image image
@gpbl
Copy link
Owner

gpbl commented Nov 14, 2024

Probably overlooked because the website has overrides that mask the problem

Oh, that's an old story. Funny thing, that larger font was actually the style I wanted to ship in v9.

Should I revert it ? 🤔

@staaky
Copy link
Author

staaky commented Nov 14, 2024

I'd revert it just because it's causing layout changes for everyone updating, and new installs will notice it's different from what's shown on the website. I prefer the regular font, but whatever you decide, I'd align the website overrides with it.

@gpbl
Copy link
Owner

gpbl commented Nov 14, 2024

I'd revert it just because it's causing layout changes for everyone updating, and new installs will notice it's different from what's shown on the website. I prefer the regular font, but whatever you decide, I'd align the website overrides with it.

@staaky thanks for the feedback! I've updated website in #2588 to match the actual style, with the larger font.

If upgrading to v9.3 changes the font of DayPicker, this maybe related to #2573 that fixes a style bug introduced since v9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants