Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The value of the input field can not clear #955

Closed
TakanoriMizuta opened this issue Nov 15, 2019 · 1 comment
Closed

The value of the input field can not clear #955

TakanoriMizuta opened this issue Nov 15, 2019 · 1 comment
Labels
bug Bug or Bug fixes

Comments

@TakanoriMizuta
Copy link

Describe the bug
Once set the date into input field,
input field value can NOT clear even when value prop set to "".

To Reproduce
https://codesandbox.io/s/7m6q1y8xmj (This sample is NOT mine, thanks gpbl!)

  1. Select some date
  2. Click 'Reset' button

Expected behavior
After clicking Reset button ,Input field makes clear.

Screenshots

  • Ver 7.4.0
    daypicker740
  • Ver 7.3.2
    daypicker732

Additional context
This issue does not occur in Ver7.3.2, only occurs in ver 7.4.0

@TakanoriMizuta TakanoriMizuta added the bug Bug or Bug fixes label Nov 15, 2019
@seowalex
Copy link

seowalex commented Jan 6, 2020

For anyone else interested, the bug seems to have been introduced in commit 81ac116, when value={this.state.typedValue || this.state.value} was changed to value={this.state.value || this.state.typedValue}. Reverting this change seems to have solved the problem for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or Bug fixes
Projects
None yet
Development

No branches or pull requests

3 participants