Fix input field clear #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gpbl can you review this? |
|
@gpbl Can you please review and accept it? I really need this for my current project and this will help a lot. Please review it!! |
|
May I know the review progress? Thank you! |
|
Please, @gpbl, can you or someone else review it? I really need it working to solve a issue in my project. |
|
Hi @gpbl , could you please review this pr? |
|
Hey @gpbl, would be great if this PR gets merged soon, thanks! |
|
@gpbl can you review this? please! |
gpbl
approved these changes
Apr 11, 2020
gpbl
added
high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typedValue: undefinedcould cause controlled/uncontrolled error since input's value calculation was changed in #816If we set
typedValue: ''then the input stays controlled, and we can clear the field correctly by setting empty string as value.Closes #977 #955