-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange behavior when clicking days with outside modifier #97
Comments
|
Do not show months for outside days (fix #97)
Thanks for the fix for the second bug! However, I think we might have messed up a little bit - instead of using |
@jkillian Our reasoning was right, because the old code is actually displaying a month based on the |
See #112 |
@jkillian these issues should be fixed in the new 1.2.0 release. There's event a new example showing the corrected behaviors. |
The first bug is that clicking outside days only changes the month if you have an
onDayClick
prop set (which is surprising behavior). This seems to be becausehandleDayClick
is only called ifprops.onDayClick
is set. I think this should maybe be opt-in behavior that happens regardless ofonDayClick
's value?The second bug is that you can use this month changing functionality to navigate to days outside of the bounds set by
fromMonth
andtoMonth
. It seems thatshowMonthForOutsideDays
doesn't check if the month is allowed or not. Perhaps instead of callingsetState
directly it should callshowMonth
instead?The text was updated successfully, but these errors were encountered: