Corrected typing for RangerModifier #1065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across a typing issue when using react-day-picker in our Typescript project.
Specifically, making use of the util function
addDayToRange
. The typing foraddDayToRange
is defined as:addDayToRange(day: Date, range: RangeModifier): RangeModifier;
.where
export interface RangeModifier { from: Date; to: Date; }
However the function
addDayToRange
, implemented inDateUtils.js
expects (and handles) null date objects (from and to) objects, which contradicts the current typing forRangeModifier
I simply changed the typing to allow for the dates to be
undefined
within theRangeModifier
object, and this solved the typing issues we were experiencing.I also noticed
RangeModifier
was defined twice, so I removed the duplicate.Cheers!