Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): replace deprecated React.SFC type #2049

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix(types): replace deprecated React.SFC type #2049

merged 1 commit into from
Apr 16, 2024

Conversation

sabotatore
Copy link

@sabotatore sabotatore commented Feb 2, 2024

Description

Replaces deprecated React.SFC type with React.FunctionComponent.

It's required to passing @types/react 18 linter check:

node_modules/react-day-picker/types/Props.d.ts:47:13 - error TS2694: Namespace 'React' has no exported member 'SFC'.

47     | React.SFC<CaptionElementProps>;

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Before submitting your pull request, please make sure the following is done:

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have followed the coding guidelines in this project
  • I have tested my changes on different browsers and screen sizes

Linked Issues

If this PR addresses any existing issues, please link them here. Example: Fixes #123

Test Plan

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Screenshots (if appropriate)

Include screenshots or GIFs if relevant. This is especially important for UI-related changes.

Further Comments

If you have any additional comments or questions, please add them here.

@sabotatore sabotatore changed the title Replace deprecated React.SFC type fix(types): replace deprecated React.SFC type Feb 2, 2024
@gpbl gpbl merged commit bf66a18 into gpbl:v7 Apr 16, 2024
3 checks passed
@gpbl
Copy link
Owner

gpbl commented Apr 16, 2024

Thanks @sabotatore for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants