Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the output files as a UMD module #216

Merged
merged 2 commits into from
Sep 29, 2016
Merged

Build the output files as a UMD module #216

merged 2 commits into from
Sep 29, 2016

Conversation

pguimera
Copy link

As the title says, I've updated webpack's output to build the file as a UMD module to improve the library's compatibility when using the built file directly.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.738% when pulling 3a77b9f on pguimera:umd-module into 4ba2b05 on gpbl:master.

Copy link
Owner

@gpbl gpbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Does this mean we can directly call the package from https://unpkg.com as well? 😃

@@ -6,3 +6,4 @@ npm-debug.log
_book
lib
_site
.idea
Copy link
Owner

@gpbl gpbl Sep 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind I'd skip this change, as it's not related to the source code :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

@@ -1,6 +1,6 @@
{
"name": "react-day-picker",
"version": "2.4.1",
"version": "2.4.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to cut a minor release (hence 2.5.0)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.738% when pulling c5f6705 on pguimera:umd-module into 4ba2b05 on gpbl:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.738% when pulling 444e84c on pguimera:umd-module into 4ba2b05 on gpbl:master.

@pguimera
Copy link
Author

I've cleaned the history a bit whilst applying the suggested changes. Also, in regards to the https://unpkg.com integration there's additional steps to be made (based from this changes) which are specified in the SUGGESTED WORKFLOW section of said page.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.738% when pulling 444e84c on pguimera:umd-module into 4ba2b05 on gpbl:master.

@gpbl gpbl merged commit 33e184f into gpbl:master Sep 29, 2016
@gpbl
Copy link
Owner

gpbl commented Sep 29, 2016

Thanks a lot! I'll work on the unpkg thing before releasing on npm.

@gpbl
Copy link
Owner

gpbl commented Oct 6, 2016

Hey @pguimera,

I've published v2.5.0. It works now from unpkg as well 🙌

@pguimera
Copy link
Author

pguimera commented Oct 6, 2016

Awesome news @gpbl, thanks for that.

I can now use this amazing library in my project without having to do weird tricks in my tooling 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants