build: improve css exports in package.json

[karlshea]

Pull Request Template

Thanks for your PR! Make sure you have read the CONTRIBUTING guide.

What's Changed

Briefly describe the changes in this pull request.

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation update

Tips for a good PR

• If you are changing code, please add tests to cover the changes.
• Some screenshots or screen recording could help to understand the changes.
• If it is a bug, please provide the code to reproduce it.

Thanks

Additional Notes

Test PR updating stylesheet exports to fix SASS file resolution using sass-loader and webpack.

[karlshea]

Is the build-website fail after you pushed up the change?

It's crazy that it's impossible to find decent docs about how module resolution is supposed to work. sass-loader says it uses webpack's resolution and they have docs here: https://webpack.js.org/configuration/resolve/

According to those what you originally had should have worked. I'll open an issue with sass-loader and see if they have any input.

[karlshea]

Discussion link here: webpack/webpack#18866

[karlshea]

Got an answer in that discussion, sass-loader checks a different key!

[karlshea]

Oh I see you fixed the import. So I guess it could go either way, the change I just pushed to add style/import/require or we could revert it back to just listing out default/types without the nested keys. Either seems to be working when I run my build.

[gpbl]

@karlshea yes I've patched your PR with some more changes.

Oh I see you fixed the import. So I guess it could go either way, the change I just pushed to add style/import/require or we could revert it back to just listing out default/types without the nested keys. Either seems to be working when I run my build.

I won't touch it anymore :D thanks for your help here hopefully will help your work.

BTW the TypeScript exports are now:

[karlshea]

Thanks for taking a look! Also would like to say thanks for the package, I spent the last several days moving a big project from moment/react-datetime to date-fns/react-day-picker and it's been very nice to work with!

[gpbl]

Thanks for taking a look! Also would like to say thanks for the package, I spent the last several days moving a big project from moment/react-datetime to date-fns/react-day-picker and it's been very nice to work with!

Thank you for your kind words and support! If you have the time, we’d love for you to share your experiences or any suggestions on how we can further improve the library.

[gpbl]

(will publish the fix later in the day...)

[karlshea]

The only thing I ran into is actually #2549 and then saw there was an open issue for it already, but it's not a huge blocker or anything. Everything else just worked how I would have hoped!