Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all! 👋
First off - this module is wonderful! 🎉 👍
Just running some accessibility audits on our app over at Buffer - we're using react-day-picker and we're getting a few errors when testing with axe-core! Nothing major, but the Week
div
should have arole="row"
instead ofrole="gridcell"
as it is a child of arole="rowgroup"
and has children withrole="gridcell"
Current role structure:
Month (grid) → Weekdays & Body (rowgroup) → Week (gridcell)→ Day (gridcell)
Proposed role structure:
Month (grid) → Weekdays & Body (rowgroup) → Week (row)→ Day (gridcell)
More on the rowgroup role in the Web Accessibility Initiative – Accessible Rich Internet Applications standards: https://www.w3.org/TR/wai-aria/roles#rowgroup
Let me know if you have any questions! 😸 thanks again!